[theme-reviewers] Include setting for paginate_comments_links or theme's custom one?

[Chip Bennett]

It really depends on your comfort level. You could open a trac ticket,
without an initial patch, describing the enhancements you want to make to
the core function. Or, submit a patch with it, and ask for feedback.
Whomever triages the ticket would usually be happy to help clean up the
patch.

Or, if you want some code feedback before submitting to Trac, WP-Hackers is
probably a good place to start.


On Mon, Jan 21, 2013 at 8:00 PM, Daniel Fenn <danielx386 at gmail.com> wrote:

> Hey Chip,
>
> Thankyou for the well written answer. Question, if the enhancement was
> for my theme only and I don't know how I can change it so that other
> people can use it (via patch), can I just start a ticket in the trac
> and put in what I got then that way others can work on it by adding
> the required hooks or filters? Or would I be better going to
> wp-hackers first?
>
> Regards,
> Daniel Fenn
>
>
>
>
>
>
> On Tue, Jan 22, 2013 at 10:28 AM, Chip Bennett <chip at chipbennett.net>
> wrote:
> > In general, *enhancing* core functionality is fine, while
> *circumventing* it
> > is not. So, if the core function can't be modified as needed via
> parameters
> > or filters, then one legitimate implementation is to provide a Theme
> option
> > for an "enhanced" version of the function.*
> >
> > I don't think the default value for the option is of any particular
> > importance.
> >
> > * The best-of-both-worlds action would be to submit the
> > improvement/enhancement to Trac as a patch to the core
> > function/functionality. Any time a Theme developer finds a way to build
> > upon/enhance a core function, I strongly recommend trying to push that
> > enhancement back upstream to core.
> >
> >
> > On Mon, Jan 21, 2013 at 6:24 PM, Daniel Fenn <danielx386 at gmail.com>
> wrote:
> >>
> >> Hi there,
> >>
> >> In the guidelines it says that we are required to use
> >> paginate_comments_links (and other hooks), is it ok to include our own
> >> custon one (the paginate_comments_links(); would have been fine but
> >> the class needs to be changed and some extra html needs to go in) and
> >> then put a setting in under theme options allowing users to chose what
> >> they want to use?
> >>
> >> Same with paginate_links(); as well.
> >>
> >> And if the answer is yes, what must be the default setting?
> >>
> >> Regards,
> >> Daniel Fenn
> >> _______________________________________________
> >> theme-reviewers mailing list
> >> theme-reviewers at lists.wordpress.org
> >> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >
> >
> >
> > _______________________________________________
> > theme-reviewers mailing list
> > theme-reviewers at lists.wordpress.org
> > http://lists.wordpress.org/mailman/listinfo/theme-reviewers
> >
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20130121/bd5eff8b/attachment.htm>