<div dir="ltr">It really depends on your comfort level. You could open a trac ticket, without an initial patch, describing the enhancements you want to make to the core function. Or, submit a patch with it, and ask for feedback. Whomever triages the ticket would usually be happy to help clean up the patch.<div>
<br></div><div>Or, if you want some code feedback before submitting to Trac, WP-Hackers is probably a good place to start.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jan 21, 2013 at 8:00 PM, Daniel Fenn <span dir="ltr"><<a href="mailto:danielx386@gmail.com" target="_blank">danielx386@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hey Chip,<br>
<br>
Thankyou for the well written answer. Question, if the enhancement was<br>
for my theme only and I don't know how I can change it so that other<br>
people can use it (via patch), can I just start a ticket in the trac<br>
and put in what I got then that way others can work on it by adding<br>
the required hooks or filters? Or would I be better going to<br>
wp-hackers first?<br>
<br>
Regards,<br>
Daniel Fenn<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
<br>
<br>
<br>
On Tue, Jan 22, 2013 at 10:28 AM, Chip Bennett <<a href="mailto:chip@chipbennett.net">chip@chipbennett.net</a>> wrote:<br>
> In general, *enhancing* core functionality is fine, while *circumventing* it<br>
> is not. So, if the core function can't be modified as needed via parameters<br>
> or filters, then one legitimate implementation is to provide a Theme option<br>
> for an "enhanced" version of the function.*<br>
><br>
> I don't think the default value for the option is of any particular<br>
> importance.<br>
><br>
> * The best-of-both-worlds action would be to submit the<br>
> improvement/enhancement to Trac as a patch to the core<br>
> function/functionality. Any time a Theme developer finds a way to build<br>
> upon/enhance a core function, I strongly recommend trying to push that<br>
> enhancement back upstream to core.<br>
><br>
><br>
> On Mon, Jan 21, 2013 at 6:24 PM, Daniel Fenn <<a href="mailto:danielx386@gmail.com">danielx386@gmail.com</a>> wrote:<br>
>><br>
>> Hi there,<br>
>><br>
>> In the guidelines it says that we are required to use<br>
>> paginate_comments_links (and other hooks), is it ok to include our own<br>
>> custon one (the paginate_comments_links(); would have been fine but<br>
>> the class needs to be changed and some extra html needs to go in) and<br>
>> then put a setting in under theme options allowing users to chose what<br>
>> they want to use?<br>
>><br>
>> Same with paginate_links(); as well.<br>
>><br>
>> And if the answer is yes, what must be the default setting?<br>
>><br>
>> Regards,<br>
>> Daniel Fenn<br>
>> _______________________________________________<br>
>> theme-reviewers mailing list<br>
>> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
>> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> theme-reviewers mailing list<br>
> <a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
> <a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
><br>
_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
</div></div></blockquote></div><br></div>