[theme-reviewers] Include setting for paginate_comments_links or theme's custom one?
sabreuse at gmail.com
Tue Jan 22 01:08:47 UTC 2013
You're welcome to open a ticket even you don't have a patch to go with
it. Be sure to explain as much as you can about what changes you're
proposing and (most importantly) why you feel this should be changed
in core and not left up to individual themes. If you just say "I want
to change this" without providing a good justification, your ticket is
much less likely to be noticed.
Alternatively, if you want to learn how to turn it into a patch
yourself, you can always ask for help in #wordpress-dev on IRC.
On Mon, Jan 21, 2013 at 8:00 PM, Daniel Fenn <danielx386 at gmail.com> wrote:
> Hey Chip,
> Thankyou for the well written answer. Question, if the enhancement was
> for my theme only and I don't know how I can change it so that other
> people can use it (via patch), can I just start a ticket in the trac
> and put in what I got then that way others can work on it by adding
> the required hooks or filters? Or would I be better going to
> wp-hackers first?
> Daniel Fenn
> On Tue, Jan 22, 2013 at 10:28 AM, Chip Bennett <chip at chipbennett.net> wrote:
>> In general, *enhancing* core functionality is fine, while *circumventing* it
>> is not. So, if the core function can't be modified as needed via parameters
>> or filters, then one legitimate implementation is to provide a Theme option
>> for an "enhanced" version of the function.*
>> I don't think the default value for the option is of any particular
>> * The best-of-both-worlds action would be to submit the
>> improvement/enhancement to Trac as a patch to the core
>> function/functionality. Any time a Theme developer finds a way to build
>> upon/enhance a core function, I strongly recommend trying to push that
>> enhancement back upstream to core.
>> On Mon, Jan 21, 2013 at 6:24 PM, Daniel Fenn <danielx386 at gmail.com> wrote:
>>> Hi there,
>>> In the guidelines it says that we are required to use
>>> paginate_comments_links (and other hooks), is it ok to include our own
>>> custon one (the paginate_comments_links(); would have been fine but
>>> the class needs to be changed and some extra html needs to go in) and
>>> then put a setting in under theme options allowing users to chose what
>>> they want to use?
>>> Same with paginate_links(); as well.
>>> And if the answer is yes, what must be the default setting?
>>> Daniel Fenn
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
More information about the theme-reviewers