[theme-reviewers] Theme Reviwers

[Emil Uzelac]

That would be nice Chip, can we do that?

@Sayontan yes sir that's not the best practice and you can use style.css
for admin pages as well, take a look at Twenty Eleven for example.
JS/Custom Styles etc is a choice, that's something we choose to do, having <div
style="background:#000;"> directly is not. Styles in elements will be
almost impossible to overwrite within a style.css for example doing this is
IMO worse than creating Theme using tables only :)

Take a look at http://themes.svn.wordpress.org/oenology/2.5/ I think that
all Themes should follow this model, also Twenty Eleven.

Emil

On Thu, May 3, 2012 at 6:36 PM, Sayontan Sinha <sayontan at gmail.com> wrote:

> - CSS Styles: <div style="background:#000;"> that's not accepted
>>
>
> Even for admin pages? I understand for a front-end facing page you would
> want the styles not to be inline so as to facilitate ease of use for a
> theme user, but specifically for things like widget options (to be shown
> under Appearance -> Widgets, not how the widget renders to an end user)
> having explicit CSS classes is probably going to be overkill.
>
>
> - jQuery Functions: Must be within a e.g. js/example.js not embedded in
>> Theme directly
>>
>
> What about dynamic JS, where wp_localize_script is not an option (E.g. JS
> code repeated within a PHP loop)? Or do you explicitly mean functions only
> (and not calls to functions)?
>
>  On Thu, May 3, 2012 at 4:20 PM, Emil Uzelac <emil at themeid.com> wrote:
>
>>  Hey Reviewers,
>>
>> As I was going over some reviews I am seeing that some of us are not
>> catching some of the obvious "issues" with the Themes.
>>
>> - Theme/Author URL: please click on them please, not only that some will
>> be SPAM but also to see if the site even exist. When I clicked on one today
>> the domain name was not even registered
>> - jQuery: Only WordPress bundled can be used, nothing else, this is
>> clearly marked in Theme Review guides
>> http://codex.wordpress.org/Theme_Review
>> - jQuery Functions: Must be within a e.g. js/example.js not embedded in
>> Theme directly
>> - CSS Styles: <div style="background:#000;"> that's not accepted
>>
>> Trac is pretty cleaned out, there's not too many Themes in it and thanks
>> all for that, however we're not competing who will review more Themes.
>> Something so obvious will need to be addressed first time around and in
>> some cases I've seen that they were not reported in couple of reviews.
>>
>> No big deal, it would be nice to pay more attention to what we are
>> looking at that's all.
>>
>> P.S. Create a plan and use that plan when reviewing Themes. I would take
>> a Theme and start with some simple stuff such as header.php > index.php >
>> footer.php than functions.php and sometimes there would be more than enough
>> required items (preliminary review only) that I would not even install a
>> Theme, SVN can tell you plenty. But that's just me.
>>
>>
>> Thanks,
>> Emil
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
>
> --
> Sayontan Sinha
> http://mynethome.net | http://mynethome.net/blog
> --
> Beating Australia in Cricket is like killing a celebrity. The death gets
> more coverage than the crime.
>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120503/dff01959/attachment-0001.htm>