[theme-reviewers] Theme Reviwers

Fri May 4 00:35:49 UTC 2012

Emil,
I do understand using a separate CSS file for the admin options and I have
been using one myself since more than 2 years, with a separate JS file
etc.: see http://themes.svn.wordpress.org/suffusion/2.0.1/admin, from
September 2010. But I don't agree about user choice being important here at
all. I am yet to come across any user who has wanted to use a different
admin stylesheet file from the one I have provided. Think of it this way:
the template files and stylesheets should be what a theme user would like
to be editing, but the admin files and stylesheets are what a theme
developer would like to be in charge of (it is the developer's brand, in a
way).

Take another case (and this is for the front end), where a featured slider
widget lets you set some colors. If you try defining CSS classes for these
colors, you will soon run into issues with the handling of multiple
featured sliders etc. Your simplest recourse here is to do an inline style,
otherwise you will have to print out the styles in your HTML markup when
the widget is rendering and force them into your <head> element using
JQuery - much ado for little.

If you try pushing this requirement too hard, then the next requirement to
come through the pipeline is going to become: "Themes must not use
$j('.selector').css({ display: 'none' }), because this prints an inline
style. Instead you should use $j('.selector').addClass('hidden'), and add
'.hidden' to your stylesheet". If you look at core WP, things like the
widget screen make inline stylesheet assignments to hide widgets.

for example doing this is IMO worse than creating Theme using tables only :)
>

I don't believe a table-based theme markup is analogous to this case at
all. For one, I am talking about specific aspects of the back-end, while
you are referring to the front-end. However, since you bring tables up, the
recommended method for using theme options, the Settings API uses tables
for its layout. Again, this is something in the back-end which is why you
haven't had users go up in arms. Of course you might argue that options are
tabular data and options are tabular, hence a table is fine in the Settings
API, but then not all theme developers like to have a tabular layout for
their options.

Anyway, this is just my point of view. I would hate to see "No inline CSS
anywhere" become a hard and fast requirement or even a recommendation for
that matter. I am not at all suggesting that all styles be inline - that
would be foolish and impractical. All I am saying is that there are some
cases where inline styles might actually save you a lot of effort and will
not affect your theme's user at all.

Sayontan.

On Thu, May 3, 2012 at 4:53 PM, Emil Uzelac <emil at themeid.com> wrote:

> That would be nice Chip, can we do that?
>
> @Sayontan yes sir that's not the best practice and you can use style.css
> for admin pages as well, take a look at Twenty Eleven for example.
> JS/Custom Styles etc is a choice, that's something we choose to do, having <div
> style="background:#000;"> directly is not. Styles in elements will be
> almost impossible to overwrite within a style.css for example doing this is
> IMO worse than creating Theme using tables only :)
>
> Take a look at http://themes.svn.wordpress.org/oenology/2.5/ I think that
> all Themes should follow this model, also Twenty Eleven.
>
> Emil
>
> On Thu, May 3, 2012 at 6:36 PM, Sayontan Sinha <sayontan at gmail.com> wrote:
>
>> - CSS Styles: <div style="background:#000;"> that's not accepted
>>>
>>
>> Even for admin pages? I understand for a front-end facing page you would
>> want the styles not to be inline so as to facilitate ease of use for a
>> theme user, but specifically for things like widget options (to be shown
>> under Appearance -> Widgets, not how the widget renders to an end user)
>> having explicit CSS classes is probably going to be overkill.
>>
>>
>> - jQuery Functions: Must be within a e.g. js/example.js not embedded in
>>> Theme directly
>>>
>>
>> What about dynamic JS, where wp_localize_script is not an option (E.g. JS
>> code repeated within a PHP loop)? Or do you explicitly mean functions only
>> (and not calls to functions)?
>>
>>  On Thu, May 3, 2012 at 4:20 PM, Emil Uzelac <emil at themeid.com> wrote:
>>
>>>  Hey Reviewers,
>>>
>>> As I was going over some reviews I am seeing that some of us are not
>>> catching some of the obvious "issues" with the Themes.
>>>
>>> - Theme/Author URL: please click on them please, not only that some will
>>> be SPAM but also to see if the site even exist. When I clicked on one today
>>> the domain name was not even registered
>>> - jQuery: Only WordPress bundled can be used, nothing else, this is
>>> clearly marked in Theme Review guides
>>> http://codex.wordpress.org/Theme_Review
>>> - jQuery Functions: Must be within a e.g. js/example.js not embedded in
>>> Theme directly
>>> - CSS Styles: <div style="background:#000;"> that's not accepted
>>>
>>> Trac is pretty cleaned out, there's not too many Themes in it and thanks
>>> all for that, however we're not competing who will review more Themes.
>>> Something so obvious will need to be addressed first time around and in
>>> some cases I've seen that they were not reported in couple of reviews.
>>>
>>> No big deal, it would be nice to pay more attention to what we are
>>> looking at that's all.
>>>
>>> P.S. Create a plan and use that plan when reviewing Themes. I would take
>>> a Theme and start with some simple stuff such as header.php > index.php >
>>> footer.php than functions.php and sometimes there would be more than enough
>>> required items (preliminary review only) that I would not even install a
>>> Theme, SVN can tell you plenty. But that's just me.
>>>
>>>
>>> Thanks,
>>> Emil
>>>
>>> _______________________________________________
>>> theme-reviewers mailing list
>>> theme-reviewers at lists.wordpress.org
>>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>>
>>>
>>
>>
>> --
>> Sayontan Sinha
>> http://mynethome.net | http://mynethome.net/blog
>> --
>> Beating Australia in Cricket is like killing a celebrity. The death gets
>> more coverage than the crime.
>>
>>
>> _______________________________________________
>> theme-reviewers mailing list
>> theme-reviewers at lists.wordpress.org
>> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>>
>>
>
> _______________________________________________
> theme-reviewers mailing list
> theme-reviewers at lists.wordpress.org
> http://lists.wordpress.org/mailman/listinfo/theme-reviewers
>
>

-- 
Sayontan Sinha
http://mynethome.net | http://mynethome.net/blog
--
Beating Australia in Cricket is like killing a celebrity. The death gets
more coverage than the crime.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120503/89523efa/attachment.htm>