<font color="#333333"><font><font face="arial,helvetica,sans-serif">That would be nice Chip, can we do that?</font></font></font><div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif">@Sayontan yes sir that's not the best practice and you can use style.css for admin pages as well, take a look at Twenty Eleven for example. JS/Custom Styles etc is a choice, that's something we choose to do, having </font></font></font><span style><div style="background:#000;"> directly is not. Styles in elements will be almost impossible to overwrite within a style.css for example doing this is IMO worse than creating Theme using tables only :)</span></div>
<div><span style><br></span></div><div><span style>Take a look at </span><font color="#333333" face="arial, helvetica, sans-serif"><a href="http://themes.svn.wordpress.org/oenology/2.5/">http://themes.svn.wordpress.org/oenology/2.5/</a> I think that all Themes should follow this model, also Twenty Eleven.</font></div>
<div><font color="#333333"><font face="arial,helvetica,sans-serif"><br></font></font></div><div><font color="#333333"><font face="arial,helvetica,sans-serif">Emil<br></font></font><br><div class="gmail_quote">On Thu, May 3, 2012 at 6:36 PM, Sayontan Sinha <span dir="ltr"><<a href="mailto:sayontan@gmail.com" target="_blank">sayontan@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
<font color="#333333" face="arial, helvetica, sans-serif">- CSS Styles: <div style="background:#000;"> that's not accepted</font><br>
</blockquote><br></div>Even for admin pages? I understand for a front-end facing page you would want the styles not to be inline so as to facilitate ease of use for a theme user, but specifically for things like widget options (to be shown under Appearance -> Widgets, not how the widget renders to an end user) having explicit CSS classes is probably going to be overkill.<div class="im">
<br>
<br><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><div><font color="#333333" face="arial, helvetica, sans-serif">- jQuery Functions: Must be within a e.g. js/example.js not embedded in Theme directly</font></div>
</blockquote><br></div>What about dynamic JS, where wp_localize_script is not an option (E.g. JS code repeated within a PHP loop)? Or do you explicitly mean functions only (and not calls to functions)?<br><br><div class="gmail_quote">
<div><div class="h5">
On Thu, May 3, 2012 at 4:20 PM, Emil Uzelac <span dir="ltr"><<a href="mailto:emil@themeid.com" target="_blank">emil@themeid.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div class="h5">
<font color="#333333"><font><font face="arial,helvetica,sans-serif">Hey Reviewers,</font></font></font><div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">As I was going over some reviews I am seeing that some of us are not catching some of the obvious "issues" with the Themes.</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif"><br></font></font></font></div><div><font color="#333333"><font><font face="arial,helvetica,sans-serif">- Theme/Author URL: please click on them please, not only that some will be SPAM but also to see if the site even exist. When I clicked on one today the domain name was not even registered</font></font></font></div>
<div><font color="#333333"><font><font face="arial,helvetica,sans-serif">- jQuery: Only WordPress bundled can be used, nothing else, this is clearly marked in Theme Review guides </font></font></font><font color="#333333" face="arial, helvetica, sans-serif"><a href="http://codex.wordpress.org/Theme_Review" target="_blank">http://codex.wordpress.org/Theme_Review</a></font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif">- jQuery Functions: Must be within a e.g. js/example.js not embedded in Theme directly</font></div><div><font color="#333333" face="arial, helvetica, sans-serif">- CSS Styles: <div style="background:#000;"> that's not accepted</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">Trac is pretty cleaned out, there's not too many Themes in it and thanks all for that, however we're not competing who will review more Themes. Something so obvious will need to be addressed first time around and in some cases I've seen that they were not reported in couple of reviews.</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">No big deal, it would be nice to pay more attention to what we are looking at that's all.</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">P.S. Create a plan and use that plan when reviewing Themes. I would take a Theme and start with some simple stuff such as header.php > index.php > footer.php than functions.php and sometimes there would be more than enough required items (preliminary review only) that I would not even install a Theme, SVN can tell you plenty. But that's just me.</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif"><br></font></div><div><font color="#333333" face="arial, helvetica, sans-serif">Thanks,</font></div>
<div><font color="#333333" face="arial, helvetica, sans-serif">Emil</font></div>
<br></div></div><div class="im">_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org" target="_blank">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></div></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><br>-- <br>Sayontan Sinha<br><a href="http://mynethome.net" target="_blank">http://mynethome.net</a> | <a href="http://mynethome.net/blog" target="_blank">http://mynethome.net/blog</a><br>
--<br>Beating Australia in Cricket is like killing a celebrity. The death gets more coverage than the crime.<br><br>
</font></span><br>_______________________________________________<br>
theme-reviewers mailing list<br>
<a href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</a><br>
<a href="http://lists.wordpress.org/mailman/listinfo/theme-reviewers" target="_blank">http://lists.wordpress.org/mailman/listinfo/theme-reviewers</a><br>
<br></blockquote></div><br></div>