[theme-reviewers] Something we need to check for3.4appearance->background

Otto otto at ottodestruct.com
Tue Jun 12 22:49:58 UTC 2012

On Tue, Jun 12, 2012 at 5:08 PM, Chip Bennett <chip at chipbennett.net> wrote:
> I think this is the incorrect behavior/assumption that core is now
> attempting to force to change.
> It does appear that such correction is going to cause some minor issues for
> child Themes. Is this something that is a major PITA, or is it more akin to
> ripping off a band-aid?

There will be no *new* issues for child themes at all. The issues in
3.4 remain exactly the same as those that were already present in 3.3.

Here's the issue that remains:
- If a theme, which was not previously defining a default image or
color, changes to now provide said default image or color, then any
site using a child theme based on that theme and which also did not
have a custom-background already set manually, will now show the
default image instead of whatever it has in the child's style.css.

This issue is the same regardless of the method of defining the
default image or color. Same exact thing happens in 3.3 alone if a
theme suddenly defines the BACKGROUND_COLOR or BACKGROUND_IMAGE

This is not a 3.4 specific issue *except* insofar as 3.4 makes it
slightly easier to define default image/color. The core itself will
change nothing in this regard.


More information about the theme-reviewers mailing list