[theme-reviewers] Something we need to checkfor3.4appearance->background

[Philip M. Hofer (Frumph)]

Best way to have put it all day Chip, thank you.   That is the underlying discussion that should be talked about. 

These are the two thoughts (as I see it)

1)
( Remove background image )  Button, in appearance –> background removes all visible instances of background image [sic: of everything, everywhere, background image is empty completely] (if) defaults are set in the parent theme.   Which end result would be that the theme designer would have to either support it or not.  If they do then all previous made child themes and plugins that override CSS would become obsolete.

2)
( Remove background image ) Button, in appearance –> background is taken as “remove background image [sic: that you set here in the appearance –> background ]” defaults to the settings in the style.css of the child theme/plugin/parent.  In which case behavior would remain consistent with not setting defaults in the arguments.   To provide end results of clearing a background image, the style.css of the parent theme does not set a background in the body.





From: Chip Bennett 
Sent: Tuesday, June 12, 2012 3:08 PM
To: theme-reviewers at lists.wordpress.org 
Subject: Re: [theme-reviewers] Something we need to checkfor3.4appearance->background

I think this is the incorrect behavior/assumption that core is now attempting to force to change. 

It does appear that such correction is going to cause some minor issues for child Themes. Is this something that is a major PITA, or is it more akin to ripping off a band-aid?

Chip


On Tue, Jun 12, 2012 at 4:48 PM, Philip M. Hofer (Frumph) <philip at frumph.net> wrote:

  Not currently, no.

  The expected behavior is reverting to the assignment by the theme.

  It has been this way since appearance –> background was introduced.

  From: Michael Fields 
  Sent: Tuesday, June 12, 2012 2:41 PM
  To: theme-reviewers at lists.wordpress.org 
  Subject: Re: [theme-reviewers] Something we need to check for3.4appearance->background


    The end user expects it to default to what the theme has.

  This is what the user expects to happen when they click "Restore Original Image". When they click "Remove Background Image" the background should be removed. just like the label says.

------------------------------------------------------------------------------

  _______________________________________________
  theme-reviewers mailing list
  theme-reviewers at lists.wordpress.org
  http://lists.wordpress.org/mailman/listinfo/theme-reviewers


  _______________________________________________
  theme-reviewers mailing list
  theme-reviewers at lists.wordpress.org
  http://lists.wordpress.org/mailman/listinfo/theme-reviewers





--------------------------------------------------------------------------------
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120612/ae04db8c/attachment-0001.htm>