[theme-reviewers] Something we need to check for 3.4 appearance -> background

[Philip M. Hofer (Frumph)]

Correct, it’s now working as it should, minus the flaw of not having enough $arguments to actually utilize the plethora of different abilities [ background: ] has.   There is no comprehensive way to tell the background image to be fixed, centered or position-x/y.

see: http://core.trac.wordpress.org/ticket/20816

ref:  wp-includes/theme.php

$defaults = array(
    'default-image' => '',
    'default-color' => '',
    'wp-head-callback' => '_custom_background_cb',
    'admin-head-callback' => '',
    'admin-preview-callback' => '',
);

Utilizing $arguments passed to add_theme_support(‘custom-background’, $args);  currently is really not complete enough to actually be useful beyond adding a repeat image.  To which end.  

When reviewing themes for this, the only thing we should worry about is if the image repeats appropriately.  There should not be a requirement nor even a suggestion for utilizing the passed $args until it is more complete and able to function appropriately with all the array of options available.

Requiring that the theme not implement any background to the body class is not necessary.  Suggestion maybe “to allow the end user to select not having a background.” sure, maybe.  Until then there’s no reason to stop the current status-quo and methodology the developers of themes currently utilize.

I foresee in the future that those $arguments being passed to the $defaults = array will include but not limited to such things as (bool)‘background-image-none’,  ‘background-position-x’, ‘background-position-y’, ‘background-attachment’, etc.   Until then it’s not responsible for us to even worry about it.   Consider the body background in the style.css to be a “fallback” and methods used to make a blank background consistent with how it is currently being done to remove said background.



From: Edward Caissie 
Sent: Tuesday, June 12, 2012 12:30 PM
To: theme-reviewers at lists.wordpress.org 
Subject: Re: [theme-reviewers] Something we need to check for 3.4 appearance -> background

On Tue, Jun 12, 2012 at 7:53 AM, Otto <otto at ottodestruct.com> wrote:

  That's too vague for me to understand. It works as it's intended to
  work, as far as I can tell.

  What specifically is the trouble?

Around 3.4-alpha it appeared to be working very similar to 3.3.2 ... somewhere around 3.4-RC2(?) it stopped "working".

Now with 3.4-RC3 it is in a state that is workable and explainable to the end-user why their Child-Theme may break and how to fix it without having to have new code added to their Child-Theme.

I still do not particularly agree with the verbiage of the buttons I am seeing depending on the options that have been or not been selected.

As it is, here is the current use-case/scenario:

1. Parent-Theme is loaded and uses custom-backgrounds with default arguments set for color and image
1a. No CSS in the body tag is used for background image or color

2. Child-Theme is loaded with no custom-background functionality added, it inherits the Parent-Theme's
2a. The Child-Theme *does* have body tag properties for background image and color

3. After updating Parent-Theme the Child-Theme background image goes away, but the Child-Theme background color remains.

4. Go to Appearance | Background and click on "Remove Background Image"

5. Child-Theme now reverts back to what the end-user expects: their background image being displayed just like it did before upgrading the Parent-Theme.

NB: At step 4 you may notice that there are no settings that actually show anything besides what their defaults would be without custom-background functionality being implemented. Thus the verbiage of "Remove Background Image" is rather misleading ... as best I can figure clicking the button it is removing the setting that dictates using the Parent-Theme background but it cannot display it as the path does not resolve(?). Of course I could be completely wrong on that notion as I have not code traced it to see if that is the case, just surmising it may be.


Cais.



--------------------------------------------------------------------------------
_______________________________________________
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
http://lists.wordpress.org/mailman/listinfo/theme-reviewers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wordpress.org/pipermail/theme-reviewers/attachments/20120612/891a4eef/attachment-0001.htm>