<HTML><HEAD></HEAD>
<BODY dir=ltr>
<DIV dir=ltr>
<DIV style="FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: 12pt">
<DIV>Correct, it’s now working as it should, minus the flaw of not having enough
$arguments to actually utilize the plethora of different abilities [ background:
] has. There is no comprehensive way to tell the background image to
be fixed, centered or position-x/y.</DIV>
<DIV> </DIV>
<DIV>see: <A title=http://core.trac.wordpress.org/ticket/20816
href="http://core.trac.wordpress.org/ticket/20816">http://core.trac.wordpress.org/ticket/20816</A></DIV>
<DIV> </DIV>
<DIV>ref: wp-includes/theme.php</DIV>
<DIV> </DIV>
<DIV>$defaults = array(</DIV>
<DIV> 'default-image' => '',</DIV>
<DIV> 'default-color' => '',</DIV>
<DIV> 'wp-head-callback' => '_custom_background_cb',</DIV>
<DIV> 'admin-head-callback' => '',</DIV>
<DIV> 'admin-preview-callback' => '',</DIV>
<DIV>);</DIV>
<DIV> </DIV>
<DIV>Utilizing $arguments passed to add_theme_support(‘custom-background’,
$args); currently is really not complete enough to actually be useful
beyond adding a repeat image. To which end. </DIV>
<DIV> </DIV>
<DIV>When reviewing themes for this, the only thing we should worry about is if
the image repeats appropriately. There should not be a requirement nor
even a suggestion for utilizing the passed $args until it is more complete and
able to function appropriately with all the array of options available.</DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV style="FONT: 10pt tahoma">
<DIV><FONT size=3 face=Calibri></FONT> </DIV>
<DIV><FONT size=3 face=Calibri>Requiring that the theme not implement any
background to the body class is not necessary. Suggestion maybe “to allow
the end user to select not having a background.” sure, maybe. Until then
there’s no reason to stop the current status-quo and methodology the developers
of themes currently utilize.</FONT></DIV>
<DIV><FONT size=3 face=Calibri></FONT> </DIV>
<DIV><FONT size=3 face=Calibri>I foresee in the future that those $arguments
being passed to the $defaults = array will include but not limited to such
things as (bool)‘background-image-none’, ‘background-position-x’,
‘background-position-y’, ‘background-attachment’, etc. Until then
it’s not responsible for us to even worry about it. Consider the
body background in the style.css to be a “fallback” and methods used to make a
blank background consistent with how it is currently being done to remove said
background.</FONT></DIV>
<DIV><FONT size=3 face=Calibri></FONT> </DIV>
<DIV> </DIV>
<DIV><FONT size=3 face=Calibri></FONT> </DIV>
<DIV style="BACKGROUND: #f5f5f5">
<DIV style="font-color: black"><B>From:</B> <A title=edward.caissie@gmail.com
href="mailto:edward.caissie@gmail.com">Edward Caissie</A> </DIV>
<DIV><B>Sent:</B> Tuesday, June 12, 2012 12:30 PM</DIV>
<DIV><B>To:</B> <A title=theme-reviewers@lists.wordpress.org
href="mailto:theme-reviewers@lists.wordpress.org">theme-reviewers@lists.wordpress.org</A>
</DIV>
<DIV><B>Subject:</B> Re: [theme-reviewers] Something we need to check for 3.4
appearance -> background</DIV></DIV></DIV>
<DIV> </DIV></DIV>
<DIV
style="FONT-STYLE: normal; DISPLAY: inline; FONT-FAMILY: 'Calibri'; COLOR: #000000; FONT-SIZE: small; FONT-WEIGHT: normal; TEXT-DECORATION: none">
<DIV class=gmail_quote>On Tue, Jun 12, 2012 at 7:53 AM, Otto <SPAN
dir=ltr><<A href="mailto:otto@ottodestruct.com"
target=_blank>otto@ottodestruct.com</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV id=:1k0>That's too vague for me to understand. It works as it's intended
to<BR>work, as far as I can tell.<BR><BR>What specifically is the
trouble?</DIV></BLOCKQUOTE></DIV><BR>Around 3.4-alpha it appeared to be working
very similar to 3.3.2 ... somewhere around 3.4-RC2(?) it stopped
"working".<BR><BR>Now with 3.4-RC3 it is in a state that is workable and
explainable to the end-user why their Child-Theme may break and how to fix it
without having to have new code added to their Child-Theme.<BR><BR>I still do
not particularly agree with the verbiage of the buttons I am seeing depending on
the options that have been or not been selected.<BR><BR>As it is, here is the
current use-case/scenario:<BR><BR>1. Parent-Theme is loaded and uses
custom-backgrounds with default arguments set for color and image<BR>1a. No CSS
in the body tag is used for background image or color<BR><BR>2. Child-Theme is
loaded with no custom-background functionality added, it inherits the
Parent-Theme's<BR>2a. The Child-Theme *does* have body tag properties for
background image and color<BR><BR>3. After updating Parent-Theme the Child-Theme
background image goes away, but the Child-Theme background color
remains.<BR><BR>4. Go to Appearance | Background and click on "Remove Background
Image"<BR><BR>5. Child-Theme now reverts back to what the end-user expects:
their background image being displayed just like it did before upgrading the
Parent-Theme.<BR><BR>NB: At step 4 you may notice that there are no settings
that actually show anything besides what their defaults would be without
custom-background functionality being implemented. Thus the verbiage of "Remove
Background Image" is rather misleading ... as best I can figure clicking the
button it is removing the setting that dictates using the Parent-Theme
background but it cannot display it as the path does not resolve(?). Of course I
could be completely wrong on that notion as I have not code traced it to see if
that is the case, just surmising it may be.<BR><BR><BR>Cais.<BR>
<P>
<HR>
_______________________________________________<BR>theme-reviewers mailing
list<BR>theme-reviewers@lists.wordpress.org<BR>http://lists.wordpress.org/mailman/listinfo/theme-reviewers<BR></DIV></DIV></DIV></BODY></HTML>