[theme-reviewers] Something we need to check for 3.4 appearance -> background
Philip M. Hofer (Frumph)
philip at frumph.net
Mon Jun 11 22:54:49 UTC 2012
As it should be. If the appearance -> background image isn't set, there
should not be a custom-background code or body class.
As I have referred many times to the reason why that you are neglecting to
You find me wrong about it, I find you wrong about your method.
You want to add steps the end user will not be familiar with *no* fallback.
Just for a single quick-option to remove all backgrounds. While the end
user has been for years now been familiar with editing the style.css
making/modifying a child theme or using a plugin.
Instead of keeping the status quo the implementation of it doesn't warrant
the difficulty in providing support for it. It's basically like telling
people to user newheader.php instead of header.php from now on.
Sent: Monday, June 11, 2012 3:49 PM
To: theme-reviewers at lists.wordpress.org
Subject: Re: [theme-reviewers] Something we need to check for 3.4
appearance -> background
Phillip, I wish you would respond with one email instead of three. I
can't multi-quote everything you're getting wrong here.
I'm trying this right now, and as it turns out, the suggested stuff
nacin wrote in that patch doesn't actually work. Without the
custom-background class, there's no way to override the style.css's
In other words, it's now completely broken, with no fix short of
requiring theme-authors to simply not specify a background-image in
the style.css (when they're also using the add-theme-support for
On Mon, Jun 11, 2012 at 5:43 PM, Philip M. Hofer (Frumph)
<philip at frumph.net> wrote:
> I like the wording, but what if the theme designer has a fallback of an
> image "by design" ?
That should be absolutely disallowed by the theme review process,
period. That is just pure broken UX.
> If the end user of the theme wants to customize it further they have
> of avenues they have been using for many years to remove a background
And now they should have a better way. That way being to click the
"Remove Background Image" button.
theme-reviewers mailing list
theme-reviewers at lists.wordpress.org
More information about the theme-reviewers