[wp-trac] [WordPress Trac] #55604: Update SimplePie to version 1.8.0
WordPress Trac
noreply at wordpress.org
Thu Sep 26 01:31:50 UTC 2024
#55604: Update SimplePie to version 1.8.0
-------------------------------------------------+-------------------------
Reporter: jrf | Owner: (none)
Type: task (blessed) | Status: new
Priority: normal | Milestone: Future
| Release
Component: External Libraries | Version: 6.0
Severity: normal | Resolution:
Keywords: needs-dev-note early needs-unit- | Focuses:
tests 2nd-opinion has-patch |
-------------------------------------------------+-------------------------
Comment (by SergeyBiryukov):
Replying to [comment:46 jrf]:
> For the record, the following two tests in the WP Core test suite would
currently fail on the version of SimplePie which is used by WP not being
compatible with PHP 8.4:
> * `WP_Test_REST_Widgets_Controller::test_get_items()`
> * `Tests_Widgets_wpWidgetRss::test_url_happy_path with data set "when
url is given"`
Spent some time looking into this, and [https://github.com/WordPress
/wordpress-develop/pull/7441 PR 7441] is my attempt at updating SimplePie
to version 1.8.0, with those tests (and all others) passing.
Replying to [ticket:55604 jrf]:
> As WP currently only includes the files in the `library` directory, I
would like to suggest to continue doing so for now.
> This still makes the ''forward-compatibility'' layer available as all
files in the `library` directory now create a ''class alias'' to their
namespaced version.
>
> Once 2.0.0 has been released, the files included in WP, should be
switched to the files from the `src` directory (which is currently in
place mostly to allow for Composer autoloading) and should start using the
namespaced names for the SimplePie classes.
It appears that PSR-4 namespaced classes are used as of 1.7.0, so in my
understanding both `library` and `src` directories are now necessary.
Would that be correct?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/55604#comment:48>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list