[wp-trac] [WordPress Trac] #55604: Update SimplePie to version 1.8.0

[WordPress Trac]

#55604: Update SimplePie to version 1.8.0
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  External Libraries                   |     Version:  6.0
 Severity:  normal                               |  Resolution:
 Keywords:  needs-dev-note early needs-unit-     |     Focuses:
  tests 2nd-opinion has-patch needs-refresh      |
-------------------------------------------------+-------------------------

Comment (by jrf):

 Replying to [comment:45 peterwilsoncc]:
 > As `WP_Feed_Cache_Transient` will need to be refactored (and possibly
 others, when I experimented I was hitting fatal errors so didn't even
 commit locally)

 @peterwilsoncc Would you like me to have a look at it ? Or maybe you want
 to set up a call for us to look at this together ?

 > and the 1.8 branch will need a new tag

 The new tag is on the way. My PRs with PHP 8.4 fixes were merged today.
 The necessary [https://github.com/simplepie/simplepie/pull/875 backports
 to the 1.8 branch] were done as well. Based on
 https://github.com/simplepie/simplepie/pull/886, I kind of expect a 1.8.1
 release some time over the next few days.


 > is there anything WP can do in the mean time to reduce the issue.
 >
 > Do you recall the level of incompatibility for 8.4: is it fatal errors,
 warnings or depredations/other notices?

 IIRC it is only deprecation notices, but in three different flavours.

 Generally speaking, that is not that much of a problem. If users open
 tickets about those, we can close them with a "''this is being addressed
 upstream and WP will update once an update is available''", but then, we
 haven't been updating, so that statement would be a bit disingenuous.

 The bigger problem, from my point of view, is that SimplePie not being
 updated to 1.8.1 means we cannot turn on test runs for WP Core against PHP
 8.4, as we want tests to fail on PHP deprecation notices to prevent new
 issues being introduced in the code base, but at this time that would mean
 the tests would fail on SimplePie.

 I suppose we could add a temporary and conditional call to
 `TestCase::markTestSkipped()` for those tests when run against PHP 8.4,
 but we'd really need to remember to remove those again once the update
 ''does'' go through.

 For the record, the following two tests in the WP Core test suite would
 currently fail on the version of SimplePie which is used by WP not being
 compatible with PHP 8.4:
 * `WP_Test_REST_Widgets_Controller::test_get_items()`
 * `Tests_Widgets_wpWidgetRss::test_url_happy_path with data set "when url
 is given"`

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55604#comment:46>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform