[wp-trac] [WordPress Trac] #55604: Update SimplePie to version 1.8.0

[WordPress Trac]

#55604: Update SimplePie to version 1.8.0
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  Future
                                                 |  Release
Component:  External Libraries                   |     Version:  6.0
 Severity:  normal                               |  Resolution:
 Keywords:  needs-dev-note early needs-unit-     |     Focuses:
  tests 2nd-opinion has-patch                    |
-------------------------------------------------+-------------------------

Comment (by jrf):

 Replying to [comment:48 SergeyBiryukov]:
 > Replying to [comment:46 jrf]:
 > > For the record, the following two tests in the WP Core test suite
 would currently fail on the version of SimplePie which is used by WP not
 being compatible with PHP 8.4:
 > > * `WP_Test_REST_Widgets_Controller::test_get_items()`
 > > * `Tests_Widgets_wpWidgetRss::test_url_happy_path with data set "when
 url is given"`
 >
 > Spent some time looking into this, and [https://github.com/WordPress
 /wordpress-develop/pull/7441 PR 7441] is my attempt at updating SimplePie
 to version 1.8.0...

 That's awesome @SergeyBiryukov ! If you don't mind, I won't look at it
 now, but will try and get to it over the next few days.

 > ..., with those tests (and all others) passing

 The tests I mentioned above would only fail on PHP 8.4 (which we're not
 running in CI yet) and if the PR is based on SimplePie 1.8.0, they should
 still be failing on PHP 8.4 (until we update to 1.8.1 once it has been
 released).

 Update: I've just ran the tests from your branch and can confirm these
 tests still fail on PHP 8.4 with multiple deprecations hiding behind each
 other, so this is as expected for now.

 > Replying to [ticket:55604 jrf]:
 > > As WP currently only includes the files in the `library` directory, I
 would like to suggest to continue doing so for now.
 > > This still makes the ''forward-compatibility'' layer available as all
 files in the `library` directory now create a ''class alias'' to their
 namespaced version.
 > >
 > > Once 2.0.0 has been released, the files included in WP, should be
 switched to the files from the `src` directory (which is currently in
 place mostly to allow for Composer autoloading) and should start using the
 namespaced names for the SimplePie classes.
 >
 > It appears that PSR-4 namespaced classes are used as of 1.7.0, so in my
 understanding both `library` and `src` directories are now necessary.
 Would that be correct?

 I think you're right. IIRC when I opened this ticket two and half years
 ago for SimplePie 1.6.0, the intention was still to do the switch-over in
 the 2.0 release, but their plans have since changed and this ended up
 going into the 1.7.0 release.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55604#comment:49>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform