[wp-trac] [WordPress Trac] #60835: Fix and improve handling of uploading of font files

[WordPress Trac]

#60835: Fix and improve handling of uploading of font files
----------------------------------------------------+---------------------
 Reporter:  azaozz                                  |       Owner:  (none)
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  6.6
Component:  Upload                                  |     Version:  6.5
 Severity:  normal                                  |  Resolution:
 Keywords:  needs-testing has-patch has-unit-tests  |     Focuses:
----------------------------------------------------+---------------------

Comment (by peterwilsoncc):

 [57868] was linked to #60652 and approved and tested on the pull request
 linked to the ticket. The change was to

 * primarily, reduce the chance ongoing maintenance of the feature would
 not result in re-introducing the infinite loop bug
 * secondly, to ensure that the hooks fired during deletion of a font
 matched the hooks fired during the uploading of a font

 Allowing the font_dir filtering to be removed was introduced in
 [https://github.com/WordPress/gutenberg/pull/52704#discussion_r1269940796
 gutenberg#52704] and unrelated to [57868].

 To be honest, your unwillingness to listen to feedback on this ticket is,
 to me, illustrating why there where so many scathing comments about the
 introduction of this feature in the
 [https://docs.google.com/spreadsheets/d/1BSc58tOyFuaIoUO7zsJLyQzhxkwZGq5GX6aaKeFDc-I/edit?usp=sharing
 release retrospective].

 Multiple contributors have indicated to me that they don't care to get
 involved in the feature as a result of this kind of attitude. This is why
 there are limited reviews of the PR linked to this ticket.

 The changes in the linked pull introduce a significant API change to the
 uploading functions, well beyond the scope of a bug fix. In the last few
 comments, you've said there is a bug with font uploads but failed to
 identify it. What is the bug you are trying to fix?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60835#comment:54>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform