[wp-trac] [WordPress Trac] #60835: Fix and improve handling of uploading of font files

[WordPress Trac]

#60835: Fix and improve handling of uploading of font files
----------------------------------------------------+---------------------
 Reporter:  azaozz                                  |       Owner:  (none)
     Type:  defect (bug)                            |      Status:  new
 Priority:  normal                                  |   Milestone:  6.6
Component:  Upload                                  |     Version:  6.5
 Severity:  normal                                  |  Resolution:
 Keywords:  needs-testing has-patch has-unit-tests  |     Focuses:
----------------------------------------------------+---------------------

Comment (by azaozz):

 > Whether to decision to allow this was intentional or an unfortunate
 mistake is of no consequence...

 Wait a minute. Are you suggesting that introducing
 `_wp_filter_font_directory()` in [57868] was also intended to allow
 plugins to bypass it by removing it from the `upload_dir` filter and
 prevent the `font_dir` filter from running? Looking at the patch again,
 and at the commit message, it seems that way!?

 This was a refactoring of that part of the code, three days before the PW
 6.5 release date that:

 - Was not tested.
 - Was not reviewed.
 - Was not discussed.
 - Doesn't even have a Trac ticket?

 Even if all of the above points are ignored, this can only be considered
 an enhancement, not a bugfix.

 @swissspidy sorry for the ping but when reviewing [57868] for committing
 it to WP 6.5-RC3 were you aware it also contains that refactoring? This
 was committed from an unrelated ticket where the code was supposed to fix
 an infinite loop. Imho it is imperative for such changes to have Trac
 tickets where they can be tested and reviewed.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/60835#comment:53>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform