[wp-trac] [WordPress Trac] #60835: Fix and improve handling of uploading of font files
WordPress Trac
noreply at wordpress.org
Wed Jun 12 22:11:32 UTC 2024
#60835: Fix and improve handling of uploading of font files
----------------------------------------------------+---------------------
Reporter: azaozz | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.6
Component: Upload | Version: 6.5
Severity: normal | Resolution:
Keywords: needs-testing has-patch has-unit-tests | Focuses:
----------------------------------------------------+---------------------
Comment (by peterwilsoncc):
@azaozz Please do not commit this patch. As I have made very clear on the
pull request, I have not approved the changes and have a big problem with
the API changes being well beyond the scope of this ticket.
As mentioned on May 7, I think the following needs to occur before making
changes to the font library uploads:
> Before making any changes to how the font library works the following
discussions need to occur:
>
> 1. What constitutes a first and second class object in WordPress
> 2. First class object that may be introduced in the future
In the same comment on May 7, I also mentioned that it may be worth
considering adding a `context` to the various upload handlers. This
feedback has also been ignored.
**To be clear and unambiguous, to commit this ticket based on my review
would be a significant misrepresentation of the outcome of that review.**
Furthermore, I disagree with your comment that the discussion on the
ticket has identified a bug introduced during the 6.5 cycle. Font uploads
work, can be filtered by plugin authors and there have been no reports
from end users to indicate otherwise.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/60835#comment:51>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list