[wp-trac] [WordPress Trac] #60835: Fix and improve handling of uploading of font files
WordPress Trac
noreply at wordpress.org
Mon Jun 24 23:57:16 UTC 2024
#60835: Fix and improve handling of uploading of font files
----------------------------------------------------+---------------------
Reporter: azaozz | Owner: (none)
Type: defect (bug) | Status: new
Priority: normal | Milestone: 6.6
Component: Upload | Version: 6.5
Severity: normal | Resolution:
Keywords: needs-testing has-patch has-unit-tests | Focuses:
----------------------------------------------------+---------------------
Comment (by peterwilsoncc):
The use of a lambda function was introduced in [57740] in an earlier
commit for #60652, from memory this was during the late beta/early RC
period. The change in the follow up commit reverted it back to the
previous behaviour committed in the Gutenberg PR I've linked to a few
times.
As I mentioned on the associated GB ticket, and linked to on the WP Trac
ticket. Changing to a Lambda function worked around the problem rather
than fix it. This introduced a maintenance burden for maintainers unaware
of the requirement to go against the WordPress coding standards in order
to avoid infinite loops.
The reason I've been asking for make posts is due to the comment on the PR
for #60652 that it seems likely more directories such as the font
directory are going to be introduced in the future and it should be
discussed how to handle them.
Again, could you please specify exactly what the bug is that you are
trying to fix by rewriting this code. As font files are being uploaded as
intended, I think this needs to be clarified before considering rewriting
the code anything but an enhancement.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/60835#comment:56>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list