[wp-trac] [WordPress Trac] #61330: Plugin Dependencies: Refresh plugin-install.php instead of redirecting on activation

[WordPress Trac]

#61330: Plugin Dependencies: Refresh plugin-install.php instead of redirecting on
activation
-------------------------------------------------+-------------------------
 Reporter:  jorbin                               |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.6
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info                                   |  administration
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 == Test Report for Woocommerce plugins

 Patch tested: https://github.com/WordPress/wordpress-develop/pull/6732

 Plugins tested: I tested all of the plugins on the 1st page of
 `woocommerce` search results. They are listed in each test section.

 === Environment

 - OS: macOS
 - Web Server: nginx
 - PHP: 7.4
 - WordPress: 6.6 `trunk` with the patch applied
 - Browser: Firefox 126.0
 - Theme: default
 - Plugins: See the listing in each test.

 === Notes:
 * May need to reset WooCommerce

 As I've been testing and retesting, I also needed to reset the transient
 in my command line tool (with the plugin not installed):

 {{{
 wp transient set _wc_activation_redirect 1
 }}}

 * How I tested:

 I varied my workflow, testing different keystrokes and combinations in and
 out of the modal.

 I also tested each plugin in 6.4.4 and 6.5.4 first before testing with the
 patch to compare the results.

 === Actual Results for Test 1: plugin without autoredirect and no
 dependencies

 With WooCommerce (v 8.9.2) installed and activated, I tested the following
 plugins (in the order left-to-right, top-to-bottom in the search results):
 * Customer Reviews for WooCommerce - v 5.50.0
 * Checkout Field Editor (Checkout Manager) for WooCommerce - v 2.0.2
 * Product Feed PRO for WooCommerce by AdTribes – WooCommerce Product Feeds
 - v 13.3.2
 * WooCommerce Cart Abandonment Recovery - v 1.2.27
 * YITH WooCommerce Wishlist - v 3.34.0
 * Discount Rules for WooCommerce – Create Smart WooCommerce Coupons &
 Discounts - v 2.6.3
 * Table Rate Shipping Method for WooCommerce by Flexible Shipping - v
 4.25.0
 * WooCommerce Weight Based Shipping - v 5.9.1
 * Advanced Product Fields (Product Addons) for WooCommerce - v 1.6.7
 * LiteSpeed Cache - v 6.2.0.1
 * Flexible Checkout Fields for WooCommerce – WooCommerce Checkout Manager
 - v 4.1.6
 * Advanced Order Export For WooCommerce - v 3.5.3

 **Actual Results**
 For all of the plugins listed above:
 * ✅ The plugin should activate and the button should show the status of
 `Active`.
 * ✅ After activation, the page should refresh / reload, but not redirect
 (i.e. it'll reload to stay on the Add Plugins UI).

 === Actual Results for Test 2: a plugin with autoredirect but no
 dependencies

 Plugins:
 * WooCommerce - v 8.9.2
 * Mailchimp for WooCommerce - v 4.0.2
 * FiboSearch – Ajax Search for WooCommerce - v 1.28.0
 * Payment Plugins for PayPal WooCommerce - v 1.0.47
 * Pinterest for WooCommerce - v 1.3.24

 **Actual Results**
 * ✅ After activation, the plugin's setup wizard should load.
 * ✅ In your browser, using its "Go back" arrow or button should (in one-
 click) return you to the Add Plugins UI.
 * ✅ Upon returning to the Add Plugins UI, the plugin's status should show
 Active.

 === Actual Results for Test 3: plugin without autoredirect when it
 requires another plugin with autodirect

 Main plugins:
 * WooCommerce Stripe Payment Gateway - v 8.3.1
 * WooCommerce PayPal Payments - v 2.7.1
 * PDF Invoices & Packing Slips for WooCommerce - v 3.8.3
 * WooCommerce Square - v 4.6.2
 * Google Analytics for WooCommerce - v 2.7.1
 * WooCommerce Shipping & Tax - v 2.6.0
 * Facebook for WooCommerce - v 3.2.3
 * Variation Swatches for WooCommerce - v 2.1.0
 * WooCommerce PDF Invoices, Packing Slips, Delivery Notes and Shipping
 Labels - v 4.5.1
 * Dokan – Best WooCommerce Multivendor Marketplace Solution – Build Your
 Own Amazon, eBay, Etsy - v 2.7.1
 * Advanced Shipment Tracking for WooCommerce - v 3.6.6
 * CTX Feed – WooCommerce Product Feed Manager Plugin - v 6.4.35
 * Wallet for WooCommerce - v 1.5.4

 Dependent plugin: WooCommerce - v 8.9.2

 **Actual Results**

 For the dependent plugin (e.g. WooCommerce):
 * ✅ After activation, its setup wizard should load.
 * ✅ In your browser, using its "Go back" arrow or button should (in one-
 click) return you to the Add Plugins UI.
 Upon returning to the Add Plugins UI, the plugin's status should show
 Active.

 For each main plugin listed above:
 * ✅ After activation, the Add Plugins UI page should reload.
 * ✅ After reloading, the plugin's status should show Active.

 === Actual Results for Test 4: plugin with autoredirect when it requires
 another plugin with autodirect

 Main Plugins:
 * Google Listings & Ads - v 2.7.1
 * Germanized for WooCommerce - v 3.16.9
 * Payment Plugins for Stripe WooCommerce - v 3.3.71
 * WooPayments: Integrated WooCommerce Payments - v 7.7.0
 * Booster for WooCommerce - v 7.2.0

 Dependent plugin: WooCommerce - v 8.9.2

 **Actual Results**

 For the dependent plugin (e.g. WooCommerce):
 * ✅ After activation, its setup wizard should load.
 * ✅ In your browser, using its "Go back" arrow or button should (in one-
 click) return you to the Add Plugins UI.
 * ✅ Upon returning to the Add Plugins UI, the plugin's status should show
 Active.

 For each main plugin listed above:
 * ✅ After activation, should redirect to its setup wizard or main setup
 page.
 * ✅ In your browser, using its "Go back" arrow or button should (in one-
 click) return you to the Add Plugins UI.
 * ✅ Upon returning to the Add Plugins UI, the plugin's status should show
 Active.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61330#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform