[wp-trac] [WordPress Trac] #61330: Plugin Dependencies: Refresh plugin-install.php instead of redirecting on activation

[WordPress Trac]

#61330: Plugin Dependencies: Refresh plugin-install.php instead of redirecting on
activation
-------------------------------------------------+-------------------------
 Reporter:  jorbin                               |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  6.6
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing has-         |     Focuses:
  testing-info                                   |  administration
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 == Test Report for single plugins with auto-redirect (no deps)

 Patch tested: https://github.com/WordPress/wordpress-develop/pull/6732

 Plugins tested, all of which have auto-redirects after activation:

 * All in One SEO (AIOSEO) - v 4.6.4
 * bbPress - v 2.6.9
 * BuddyPress - v 12.5.0
 * Donation Forms by Charitable - v 1.8.1.7
 * Duplicator – Migration & Backup Plugin - v 1.5.9
 * *Easy Digital Downloads (EDD) - v 3.2.12
 * Event Tickets and Registration - v 5.10.0
 * ExactMetrics - v 7.27.0
 * *Gallery Plugin for WordPress - Envira Photo Gallery - v 1.8.12
 * Giveaways and Contests by RafflePress - v 1.12.14
 * MonsterInsights - v 8.27.0
 * NextGEN Gallery by Imagely - v 3.59.3
 * OptinMonster - v 2.16.2
 * *Paid Membership Pro - v 3.0.4
 * SearchWP Live Ajax Search - v 1.8.2
 * Smash Balloon Social Photo Feed - v 6.3.1
 * Smash Balloon Social Post Feed - v 4.2.5
 * *Stripe Payment Forms by WP Simple Pay - v 4.10.0
 * The Event Calendar - v 6.5.0.1
 * *Website Builder by SeedProd - v 6.17.4
 * WPForms Lite - v 1.8.8.3
 * *WP Mail SMTP - v 4.0.1
 * *Yoast SEO - v 22.8

 `*` indicates the plugin only redirects after the first activation.
 Deactivating and then reactivating will not load it again. Neither will
 deleting the plugin and repeating.

 === Environment

 - OS: macOS
 - Web Server: nginx
 - PHP: 7.4
 - WordPress: 6.6 `trunk` with the patch applied
 - Browser: Firefox 126.0
 - Theme: default
 - Plugins: See above.

 === Notes

 My workflow in these tests:

 Started with 6.4.4:
 1. Navigated to the Add Plugins UI.
 2. Typed the name of the plugin the search box.
 3. Install > Activate using the plugin's card.
 4. After redirect to plugin's experience, clicked the browser's Go Back
 button, which returned me to the Add Plugins UI screen.
 5. Clicked the Go Back again to return to the `plugins.php` screen.
 6. Deactivated the plugin.
 7. Activated the plugin.
 8. After redirect to plugin's experience, clicked the browser's Go Back
 button, which returned me to `plugins.php` screen.
 9. Deactivated and deleted the plugin.

 Then tested with 6.5.4:
 1. Navigated to the Add Plugins UI.
 2. Typed the name of the plugin the search box.
 3. Install > Activate using the plugin's card.
 4. After redirect to plugin's experience, clicked the browser's Go Back
 button, which returned me to the Add Plugins UI screen.
 5. Clicked the Go Back again to return to the `plugins.php` screen.
 6. Deactivated the plugin.
 7. Activated the plugin.
 8. After redirect to plugin's experience, clicked the browser's Go Back
 button, which returned me to `plugins.php` screen.
 9. Deactivated the plugin.
 10. Clicked the "View details" click.
 11. Activated the plugin in the modal.
 12. After redirect to plugin's experience, clicked the browser's Go Back
 button, which returned me to `plugins.php` screen.
 13. Deactivated the plugin.
 14. Navigated to the Add Plugins UI.
 15. Searched again for the plugin.
 16. In the plugin's card, clicked the "View Details" click.
 17. In the modal, clicked the Activate button.
 18. After redirect to plugin's experience, clicked the browser's Go Back
 button, which returned me to Add Plugins UI screen.
 19. Clicked Go Back again to return to `plugins.php` screen.
 20. Deactivated and deleted the plugin.

 Then tested with 6.6 with the patch applied:
 Same steps as 6.5.4.

 === Actual Results for Test 2: a plugin with autoredirect but no
 dependencies

 * ✅ After activation, the plugin's setup wizard should load.
 * ✅ In your browser, using its "Go back" arrow or button should (in one-
 click) return you to the Add Plugins UI.
 * ✅ Upon returning to the Add Plugins UI, the plugin's status should show
 Active.
 * ✅ All plugins in the list worked the same in 6.4.4, 6.5.4, and 6.6 with
 the patch.

 Exception:
 * bbPress
   * 6.4.4 `plugins.php` screen - does not redirect with 1st activation,
 but does with the next activation or on refresh.
   * ❌ 6.6 with the patch: does not redirect when activating in the Add
 Plugins UI, but does when returning to `plugins.php` screen or when a
 redirect happens such as activating another plugin within Add Plugins UI.
 For the latter, the other plugin being activated does not complete its
 activation.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61330#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform