[wp-trac] [WordPress Trac] #56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a public function
WordPress Trac
noreply at wordpress.org
Fri Jan 20 00:43:42 UTC 2023
#56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a
public function
-------------------------------------------------+-------------------------
Reporter: oandregal | Owner:
| hellofromTonya
Type: enhancement | Status: reopened
Priority: normal | Milestone: 6.2
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: dev-feedback gutenberg-merge has- | Focuses:
patch has-unit-tests has-testing-info | performance
-------------------------------------------------+-------------------------
Comment (by azaozz):
Replying to [comment:50 flixos90]:
> For now, I went with the approach of not using the cache if `!
is_admin()`, which fixes the problem in a simpler way.
Yep, it fixes it but using is_admin() may seem a bit like going around it?
> If you prefer to stub the `wp_cache_*()` functions, that would make it a
bit more resilient...
Think so too. In addition it would make it the same as the existing way of
handling such cases, and perhaps a bit more readable? So perhaps
https://github.com/WordPress/wordpress-develop/pull/3872 is the better
approach.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/56975#comment:59>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list