[wp-trac] [WordPress Trac] #56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a public function

WordPress Trac noreply at wordpress.org
Fri Jan 20 00:54:51 UTC 2023


#56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a
public function
-------------------------------------------------+-------------------------
 Reporter:  oandregal                            |       Owner:
                                                 |  hellofromTonya
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.2
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback gutenberg-merge has-    |     Focuses:
  patch has-unit-tests has-testing-info          |  performance
-------------------------------------------------+-------------------------

Comment (by azaozz):

 Replying to [comment:58 Otto42]:
 > But it seems like we should stub out this function entirely, since it's
 not needed to create a list of file URLs. Frankly, it doesn't seem like
 this function belongs in this file.

 Yea, it doesn't seem to belong in script-loader...

 > Something fundamentally is wrong here, and it needs to be addressed
 before any further changes happen.

 Seems there were few recent additions to script-loader that depart from
 it's main purpose. As far as I see maybe a script-loader-functions.php
 file is needed for all the additional things there.

 On the the other hand it seems it's time to retire load-scripts.php and
 load-styles.php? load-scripts.php has been broken for quite a while now,
 only works for some of the old scripts. Also when HTTP/2 is used, it seems
 better to have separate tags (better network and browser caching), not to
 have different concatenated subsets of the css files.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56975#comment:60>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list