[wp-trac] [WordPress Trac] #56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a public function

WordPress Trac noreply at wordpress.org
Fri Jan 20 00:37:54 UTC 2023


#56975: Replace the internal `WP_Theme_JSON_Resolver::theme_has_support()` with a
public function
-------------------------------------------------+-------------------------
 Reporter:  oandregal                            |       Owner:
                                                 |  hellofromTonya
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  6.2
Component:  Themes                               |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  dev-feedback gutenberg-merge has-    |     Focuses:
  patch has-unit-tests has-testing-info          |  performance
-------------------------------------------------+-------------------------

Comment (by Otto42):

 Replying to [comment:57 azaozz]:
 > Stubbing is how script-loader is used (for better or worse) in load-
 styles.php and load-scripts.php. I.e. only the list of file URLs is used,
 everything else is ignored.

 Hey, I'm with you on that part. But it seems like we should stub out this
 function entirely, since it's not needed to create a list of file URLs.
 Frankly, it doesn't seem like this function belongs in this file.

 Something fundamentally is wrong here, and it needs to be addressed before
 any further changes happen.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/56975#comment:58>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list