[wp-trac] [WordPress Trac] #55860: Add Pocket Casts as an oEmbed provider
WordPress Trac
noreply at wordpress.org
Fri Jun 17 03:01:54 UTC 2022
#55860: Add Pocket Casts as an oEmbed provider
-------------------------+-----------------------------
Reporter: mattwondra | Owner: (none)
Type: enhancement | Status: reopened
Priority: normal | Milestone: Future Release
Component: Embeds | Version:
Severity: normal | Resolution:
Keywords: | Focuses:
-------------------------+-----------------------------
Changes (by peterwilsoncc):
* status: closed => reopened
* resolution: worksforme =>
* milestone: => Future Release
Comment:
Thanks for the link to the Gutenberg ticket, @pento.
> That said, this seems like a good opportunity to formalise the practice:
do we intentionally keep the lists in sync (even if the occasional embed
provider doesn't strictly need to be added to the allow list), or do we
allow them to fall out of sync?
I've reopened this ticket as I think it's important for providers with a
core embed block to be included on the allow list regardless of whether
it's technically needed.
Rather than the niceties of consistency, I'm treating this more as a
defensive coding technique. If the embed markup changes at a future date,
we risk an external provider being able to break a core block.
I've put this on the future release milestone and will monitor the
Gutenberg ticket to ensure both the block and the allow list update go in
to the same release.
@mattwondra do you have any bandwidth to create a patch, it would be
lovely to get you a contributor badge on your first ticket.
It would also be great of some docs could be created for the oembed
endpoint on a pocketcasts owned property. They don't need to be super
detailed, just something to indicate it's likely to stick around. For
example: https://github.com/someecards/someecards-developer-
docs/blob/master/oembed.md
--
Ticket URL: <https://core.trac.wordpress.org/ticket/55860#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list