[wp-trac] [WordPress Trac] #55860: Add Pocket Casts as an oEmbed provider
WordPress Trac
noreply at wordpress.org
Fri Jun 17 00:58:44 UTC 2022
#55860: Add Pocket Casts as an oEmbed provider
-------------------------+-------------------------
Reporter: mattwondra | Owner: (none)
Type: enhancement | Status: closed
Priority: normal | Milestone:
Component: Embeds | Version:
Severity: normal | Resolution: worksforme
Keywords: | Focuses:
-------------------------+-------------------------
Comment (by pento):
I've been thinking about this ticket a little bit. There's
[https://github.com/WordPress/gutenberg/pull/41006 a corresponding PR] to
add Pocket Casts to Gutenberg, which I have no concern with.
The issue I'm pondering is that we've historically kept the Gutenberg
embed variations list and the oEmbed allow list in sync: this just happens
to be the first instance (that I'm aware of) of an embed provider that
already works with auto-discovery.
Since the practice of keeping them in sync has been driven by necessity,
rather than a formal requirement, it's not a huge deal to break away from
it. That said, this seems like a good opportunity to formalise the
practice: do we intentionally keep the lists in sync (even if the
occasional embed provider doesn't strictly need to be added to the allow
list), or do we allow them to fall out of sync?
It's worth noting that they're not entirely in sync right now: Meetup was
[https://github.com/WordPress/gutenberg/issues/35085 removed from
Gutenberg], but not Core; and it looks like Someecards was added to Core,
but never to Gutenberg.
@peterwilsoncc: Do you have thoughts on what would be the more
maintainable practice?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/55860#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list