[wp-trac] [WordPress Trac] #55860: Add Pocket Casts as an oEmbed provider
WordPress Trac
noreply at wordpress.org
Tue Jun 21 15:39:35 UTC 2022
#55860: Add Pocket Casts as an oEmbed provider
-------------------------+-----------------------------
Reporter: mattwondra | Owner: (none)
Type: enhancement | Status: reopened
Priority: normal | Milestone: Future Release
Component: Embeds | Version:
Severity: normal | Resolution:
Keywords: | Focuses:
-------------------------+-----------------------------
Comment (by mattwondra):
Thanks for the help @pento and @peterwilsoncc!
I've [https://make.wordpress.org/core/handbook/tutorials/installing-a
-local-server/installing-vvv/ set up the local trunk environment on my Mac
with VVV], added Pocket Casts to the allowlist, and tested it. Now I'm
trying to [https://make.wordpress.org/core/handbook/tutorials/working-
with-patches/#upload-a-patch-from-the-command-line upload a patch with
grunt] but I'm getting permission errors:
{{{
src [master] $ grunt upload_patch:55860
package.json has not been modified.
Running "upload_patch:55860" (upload_patch) task
? Enter your WordPress.org username mattwondra
? Enter your WordPress.org password [hidden]
Warning: Something went wrong when attempting to upload the patch. Please
confirm your credentials and the ticket number. Error: XML-RPC fault:
XML_RPC privileges are required to perform this operation. You don't have
the required permissions. Use --force to continue.
Aborted due to warnings.
}}}
Any ideas what I could be doing wrong? Here's the diff:
{{{
Index: wp-includes/class-wp-oembed.php
===================================================================
--- wp-includes/class-wp-oembed.php (revision 53547)
+++ wp-includes/class-wp-oembed.php (working copy)
@@ -104,6 +104,7 @@
'#https?://(www\.)?tiktok\.com/.*/video/.*#i' =>
array( 'https://www.tiktok.com/oembed', true ),
'#https?://([a-z]{2}|www)\.pinterest\.com(\.(au|mx))?/.*#i' => array(
'https://www.pinterest.com/oembed.json', true ),
'#https?://(www\.)?wolframcloud\.com/obj/.+#i' =>
array( 'https://www.wolframcloud.com/oembed', true ),
+ '#https?://pca\.st/.+#i' =>
array( 'https://pca.st/oembed.json', true ),
);
if ( ! empty( self::$early_providers['add'] ) ) {
@@ -181,6 +182,7 @@
* | TikTok | tiktok.com
| 5.4.0 |
* | Pinterest | pinterest.com
| 5.9.0 |
* | WolframCloud | wolframcloud.com
| 5.9.0 |
+ * | Pocket Casts | pocketcasts.com
| 6.0.1 |
*
* No longer supported providers:
*
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/55860#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list