[wp-trac] [WordPress Trac] #51827: When a plugin makes use of the 'automatic_updater_disabled' filter, it causes a PHP Warning to be thrown.

[WordPress Trac]

#51827: When a plugin makes use of the 'automatic_updater_disabled' filter, it
causes a PHP Warning to be thrown.
-----------------------------+-----------------------
 Reporter:  jamesros161      |       Owner:  audrasjb
     Type:  defect (bug)     |      Status:  accepted
 Priority:  normal           |   Milestone:  5.6
Component:  Upgrade/Install  |     Version:  5.6
 Severity:  normal           |  Resolution:
 Keywords:  has-screenshots  |     Focuses:
-----------------------------+-----------------------
Changes (by azaozz):

 * keywords:  has-screenshots has-patch => has-screenshots


Comment:

 Replying to [comment:11 pbiron]:
 > Taking a quick look, I ''think'' the original logic is incorrect
 regarding setting `$can_set_update_option = false;` when
 `AUTOMATIC_UPDATER_DISABLED` is defined but false.

 Right. The logic there is two-fold (afaik):

 1. If `AUTOMATIC_UPDATER_DISABLED` is defined OR if the
 `'automatic_updater_disabled'` filter is used, the UI to set user
 preference should be disabled.
 2. If `true === AUTOMATIC_UPDATER_DISABLED` OR `true === apply_filters(
 'automatic_updater_disabled', false )`, set `$upgrade_dev = false;
 $upgrade_minor = false; $upgrade_major = false;`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51827#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform