[wp-trac] [WordPress Trac] #51827: When a plugin makes use of the 'automatic_updater_disabled' filter, it causes a PHP Warning to be thrown.

[WordPress Trac]

#51827: When a plugin makes use of the 'automatic_updater_disabled' filter, it
causes a PHP Warning to be thrown.
---------------------------------------+-----------------------
 Reporter:  jamesros161                |       Owner:  audrasjb
     Type:  defect (bug)               |      Status:  accepted
 Priority:  normal                     |   Milestone:  5.6
Component:  Upgrade/Install            |     Version:  5.6
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+-----------------------

Comment (by pbiron):

 Thanx for the patch James.

 Taking a quick look, I ''think'' the original logic is incorrect regarding
 setting `$can_set_update_option = false;` when
 `AUTOMATIC_UPDATER_DISABLED` is defined but false.

 That is, if I set that constant to false (and don't return true from
 `automatic_updater_disabled`) I ''think'' the enable/disable action links
 should be displayed.

 So, the proposal by @audrasjb ''might'' be a better fix.  @helen what do
 you think?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51827#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform