[wp-trac] [WordPress Trac] #51827: When a plugin makes use of the 'automatic_updater_disabled' filter, it causes a PHP Warning to be thrown.

[WordPress Trac]

#51827: When a plugin makes use of the 'automatic_updater_disabled' filter, it
causes a PHP Warning to be thrown.
-----------------------------+-----------------------
 Reporter:  jamesros161      |       Owner:  audrasjb
     Type:  defect (bug)     |      Status:  accepted
 Priority:  normal           |   Milestone:  5.6
Component:  Upgrade/Install  |     Version:  5.6
 Severity:  normal           |  Resolution:
 Keywords:  has-screenshots  |     Focuses:
-----------------------------+-----------------------

Comment (by azaozz):

 Replying to [comment:12 azaozz]:
 > Replying to [comment:11 pbiron]:
 > > Taking a quick look, I ''think'' the original logic is incorrect
 regarding setting `$can_set_update_option = false;` when
 `AUTOMATIC_UPDATER_DISABLED` is defined but false.
 >
 > Right. The logic there is two-fold (afaik):

 Hmm, actually no, that's incorrect (double negatives, lol).

 The logic is/should be that if `AUTOMATIC_UPDATER_DISABLED` is set and
 false, it is equivalent to not being set, i.e. the updater is not
 disabled. Same for the `'automatic_updater_disabled'` filter. So it should
 be checking only if any of the two is `true` (updater is disabled). Patch
 coming up.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51827#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform