[wp-trac] [WordPress Trac] #37110: Update to jQuery 3.*
WordPress Trac
noreply at wordpress.org
Fri Jul 31 17:10:20 UTC 2020
#37110: Update to jQuery 3.*
-------------------------------------------------+-------------------------
Reporter: jorbin | Owner: (none)
Type: task (blessed) | Status: reopened
Priority: normal | Milestone: 5.5
Component: External Libraries | Version:
Severity: critical | Resolution:
Keywords: early has-patch needs-testing | Focuses: javascript
needs-screenshots has-dev-note commit |
-------------------------------------------------+-------------------------
Comment (by desrosj):
Replying to [comment:154 apedog]:
> If my suggestion is to be given serious consideration, then:
Just wanted to make sure any disagreement expressed here was not
interpreted as not taking any ideas expressed here seriously. Any and all
concerns/ideas are taken seriously. But opinions and conclusions will be
made when evaluating the information available.
@apedog The outline and plan that you described is exactly what `jquery-
migrate` does. If a debug mode is on, it will throw console warnings. The
1.4.x version of jQuery Migrate has been in WP core for over 4 years since
[37072]. If developers have not noticed these notices with debug mode
enabled and fixed them by now, then this method of bringing compatibility
issues to their attention is not going to work for the remaining plugins
and themes.
> I'm immensely impressed by the care the auto-updates team has taken to
facilitate as smooth a transition as possible and as little breakage as
possible. Would love to see the same happen here.
I don't think this is an apples to apples comparison. Auto-updates (which
many folks that have participated on this ticket also helped with that
effort, including myself) has been possible since 3.7, but the usage was
very low (lower than jQuery 1.12.x by far) because it required developer
knowledge, or the use of a plugin specifically meant to enable and manage
feature.
> The downside is that it requires plugins and themes to be changed to
enqueue migrate, but this will stop working for very old code in 5.6
@azaozz If a plugin or theme adds an enqueue for jQuery migrate, they are
acknowledging that they are aware of the problem, researched why it
happened, and made a purposeful change to temporarily fix the issue. If
they then do not update the code in the next 3-5 months before 5.6, then
that's on them at that point, in my opinion. If they do update their code,
then in 5.6 when `jquery-migrate` is updated to the latest version, then
there would be no problems as Core intends to re-add migrate as an
enqueue. The only difference is that it will be for migrating to a newer
version of jQuery.
As for creating a plugin or polyfill to solve this (other than
[attachment:"37110-add-dependency.diff"]), I am still of the opinion that
creating a custom wheel here should be avoided. If it's decided that there
is enough potential for breakage that action should be taken, then my vote
would be to revert [48323] and use a more aggressive outreach program
(emailing plugin and theme authors directly, and often).
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37110#comment:157>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list