[wp-trac] [WordPress Trac] #47699: Remove redundant JSON polyfills for PHP native functionality

[WordPress Trac]

#47699: Remove redundant JSON polyfills for PHP native functionality
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:  desrosj
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.3
Component:  General                              |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:  coding-
  note close                                     |  standards
-------------------------------------------------+-------------------------

Comment (by dd32):

 Replying to [comment:18 jrf]:
 > > Thankfully the upgrade process can be blocked, and so no rollback
 functionality is required, a change to wp-admin/includes/update-core.php
 like the following should do the job: https://github.com/dd32/wordpress-
 develop/commit/db7e0e68ead2b58a2fb651b276a3f54380473d5e
 >
 > Wouldn't (a variation of) that change, .... [snip]
 >
 > Or is the `update-core.php` file from the ''new'' version used even
 before the files are copied over ?

 Exactly this, the `update-core.php` file in core is not used for the
 current upgrade process, it gets copied from the new version of WordPress
 being installed and then executed - taking over the upgrade process from
 the old version of WordPress; Allowing us to ship fixes/changes to the
 upgrade process no matter what version they're upgrading from.

 As a result, the one that's present on sites at present has run it's
 course as it was ''only'' used for the upgrade TO the version that's
 currently installed, never again. Hopefully that makes sense?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47699#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform