[wp-trac] [WordPress Trac] #47699: Remove redundant JSON polyfills for PHP native functionality
WordPress Trac
noreply at wordpress.org
Tue Sep 24 20:39:36 UTC 2019
#47699: Remove redundant JSON polyfills for PHP native functionality
-------------------------------------------------+-------------------------
Reporter: jrf | Owner: desrosj
Type: task (blessed) | Status: reviewing
Priority: normal | Milestone: 5.3
Component: General | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests needs-dev- | Focuses: coding-
note close | standards
-------------------------------------------------+-------------------------
Comment (by jrf):
@dd32
> I finally wrote a ticket proposing some stat collection of PHP extension
in use: #48116.
Excellent! 👍🏻👍🏻 Want me to look over the patch ?
> Thankfully the upgrade process can be blocked, and so no rollback
functionality is required, a change to wp-admin/includes/update-core.php
like the following should do the job: https://github.com/dd32/wordpress-
develop/commit/db7e0e68ead2b58a2fb651b276a3f54380473d5e
Wouldn't (a variation of) that change, including a version check with the
intended version to upgrade to, need to go into the `update-core.php` core
file of every single minor which is still supported ? And warrant a patch
release for all of them ?
Or is the `update-core.php` file from the ''new'' version used even before
the files are copied over ? (Sorry, never looked into that part of WP that
deeply, so I honestly don't know)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/47699#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list