[wp-trac] [WordPress Trac] #47699: Remove redundant JSON polyfills for PHP native functionality

WordPress Trac noreply at wordpress.org
Wed Sep 25 12:34:00 UTC 2019

#47699: Remove redundant JSON polyfills for PHP native functionality
 Reporter:  jrf                                  |       Owner:  desrosj
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.3
Component:  General                              |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-dev-  |     Focuses:  coding-
  note close                                     |  standards

Comment (by jrf):

 @dd32 Makes perfect sense to me and makes life so much easier in this
 case. Whoever thought this up: 💖

 As you already drafted that last patch which is needed for this ticket,
 would you like to upload a patch or would you prefer I work this out
 further ?

 Should this be set up in a way that both Site Health as well as the
 `update-core.php` file can use the same list of required extensions ?
 I'm in two minds about this as Site Health does a check ''after''
 install/upgrade, while `update-core` will block upgrades ''before'' they
 are rolled out.

 Maybe an inline comment in Site Health to update the list in `update-core`
 whenever an extension gets set to `required` and visa versa would suffice

Ticket URL: <https://core.trac.wordpress.org/ticket/47699#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list