[wp-trac] [WordPress Trac] #48249: Check for int instead of null in new submenu priority implementation
WordPress Trac
noreply at wordpress.org
Tue Oct 22 14:18:05 UTC 2019
#48249: Check for int instead of null in new submenu priority implementation
-------------------------------------------------+-------------------------
Reporter: david.binda | Owner: audrasjb
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.3
Component: Menus | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch commit dev-reviewed i18n- | Focuses:
change |
-------------------------------------------------+-------------------------
Changes (by audrasjb):
* keywords: has-patch commit dev-reviewed => has-patch commit dev-reviewed
i18n-change
Comment:
`48249.2.diff` looks great to me as well.
I think it would be better to directly implement this patch in 5.3, even
if we are in hard string freeze: it's a totally new string, not a
replacement of a previous string so polyglotâs previous work is not
trashed.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48249#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list