[wp-trac] [WordPress Trac] #48249: Check for int instead of null in new submenu priority implementation
WordPress Trac
noreply at wordpress.org
Tue Oct 22 17:17:08 UTC 2019
#48249: Check for int instead of null in new submenu priority implementation
-------------------------------------------------+-------------------------
Reporter: david.binda | Owner: audrasjb
Type: defect (bug) | Status: reviewing
Priority: normal | Milestone: 5.3
Component: Menus | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch commit dev-reviewed i18n- | Focuses:
change |
-------------------------------------------------+-------------------------
Comment (by azaozz):
Both 48249.diff​ and 48249.2.diff look good, but I tend to agree with
@desrosj [https://core.trac.wordpress.org/ticket/48249#comment:11 comment
11]. String freeze is a string freeze :) It would be nice to have the
doing-it-wrong now, but it's not essential, best to add it in a separate
ticket later.
For this ticket 48249.diff looks better.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/48249#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list