[wp-trac] [WordPress Trac] #48249: Check for int instead of null in new submenu priority implementation

WordPress Trac noreply at wordpress.org
Tue Oct 22 13:07:35 UTC 2019


#48249: Check for int instead of null in new submenu priority implementation
-------------------------------------------+------------------------
 Reporter:  david.binda                    |       Owner:  audrasjb
     Type:  defect (bug)                   |      Status:  reviewing
 Priority:  normal                         |   Milestone:  5.3
Component:  Menus                          |     Version:  trunk
 Severity:  normal                         |  Resolution:
 Keywords:  has-patch commit dev-reviewed  |     Focuses:
-------------------------------------------+------------------------

Comment (by desrosj):

 [attachment:"48249.2.diff"] adds the `_doing_it_wrong()` notice. I
 expanded it slightly.

 @SergeyBiryukov Consider this my sign off on both
 [attachment:"48249.diff"] and [attachment:"48249.2.diff"]. Since you have
 more i18n experience than me, I'll defer to your judgement about
 introducing this new string during RC. But, I think this one could be OK
 since this is not a user facing string.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48249#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list