[wp-trac] [WordPress Trac] #34904: The design of the focus outline on buttons/elements could be improved

[WordPress Trac]

#34904: The design of the focus outline on buttons/elements could be improved
-------------------------------------------------+-------------------------
 Reporter:  michaelarestad                       |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.3
Component:  Administration                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-post-mortem color-contrast     |     Focuses:  ui,
  blessed wpcampus-report has-patch has-         |  accessibility
  screenshots needs-dev-note 5-3-admin-css-      |
  changes                                        |
-------------------------------------------------+-------------------------
Changes (by afercia):

 * type:  enhancement => defect (bug)


Comment:

 > Re: process, this is a low-priority enhancement that shouldn't have been
 committed during or right before beta.

 I'm sorry but insufficient contrast and poor focus indication are a
 serious accessibility bug. Worth also noting #47151 was closed in favor of
 this ticket. #47151 comes from the WPCampus accessibility report on
 Gutenberg and outlined the contrast issue on buttons.

 Being a bug, it can be committed at any time during Beta period.

 > Changes to the buttons styling affect a lot of other (old) CSS,
 potentially breaking many many plugins.

 I'd appreciate concrete examples of breakages regarding the buttons
 styling. I haven't seen any so far. Also, plugins shouldn't alter the
 default styling buttons and if they do, they're just "doing it wrong".

 Worth also noting that the changes to the focus style improve
 accessibility ''and'' also bring in consistency with the styles used in
 Gutenberg. Previously, there were two complete different patterns in
 WordPress: the Gutenberg one and the legacy admin one. I'm not sure that
 can be considered a good UI. Harmonization of the styles in the admin
 needs to happen anyways sooner or later.

 Considering this is an accessibility bug, I'd like to change the ticket to
 "bug" (#47151 was marked as bug). Worth also noting this ticket was
 changed to "blessed task" by the Editor Tech focus lead for this release
 cycle @youknowriad and I couldn't agree more :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/34904#comment:118>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform