[wp-trac] [WordPress Trac] #49059: Whitespace inside p element in wp-signup.php should be removed
WordPress Trac
noreply at wordpress.org
Wed Dec 25 05:39:41 UTC 2019
#49059: Whitespace inside p element in wp-signup.php should be removed
--------------------------------+------------------------------------------
Reporter: henry.wright | Owner: (none)
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.4
Component: Networks and Sites | Version: 3.0
Severity: normal | Resolution:
Keywords: close | Focuses: multisite, coding-standards
--------------------------------+------------------------------------------
Comment (by johnjamesjacoby):
> This is not a "keyword war" :)
You removed mine and added yours. You disagree with my opinion and I
disagree with yours. Would you like it if I removed your keyword and put
mine back? Of course not.
> Over the last couple of days I've been trying to convince you and the
original poster that even small changes like this one have to be assessed
from all possible sides.
We assessed all of those sides ourselves, and came to a different
conclusion.
> The proposed change is a small enhancement to the outputted HTML white
space and at the same time a small decrease to source code readability
mostly because it removes code highlighting.
These are your opinions and are not representative of the coding standards
or the opinions of others in this ticket. And the syntax highlighting is
abysmal with no change due to the lack of surrounding whitespace.
> Sorry if you feel that way, and yes, this is causing me a lot of
anxiety too. All I tried to do was a simple review of a small code change
that seems to slightly enhance one thing but slightly diminish another.
We all have good intentions, and we all are trying our best, even when we
do not agree. I choose to believe that’s a baseline understanding,
particularly for all of us in this conversation after all of our lovely
years together. 🤝
I’d like to see some action taken in this multisite file to resolve this
issue. We have a proposed patch on the floor that a multisite component
maintainer would like to commit. @azaozz how would you like to proceed?
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49059#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list