[wp-trac] [WordPress Trac] #49059: Whitespace inside p element in wp-signup.php should be removed

WordPress Trac noreply at wordpress.org
Tue Dec 24 18:48:37 UTC 2019


#49059: Whitespace inside p element in wp-signup.php should be removed
--------------------------------+------------------------------------------
 Reporter:  henry.wright        |       Owner:  (none)
     Type:  enhancement         |      Status:  assigned
 Priority:  normal              |   Milestone:  5.4
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  close               |     Focuses:  multisite, coding-standards
--------------------------------+------------------------------------------

Comment (by azaozz):

 Replying to [comment:23 johnjamesjacoby]:

 > I added the commit keyword originally, and you removed it. Keyword wars
 are uncooperative.

 This is not a "keyword war" :) In my opinion this is not a good change to
 make. Removing the "commit" keyword is the result of that review. I'm
 sorry if I'm failing to express that more convincingly/in better words.

 Over the last couple of days I've been trying to convince you and the
 original poster that even small changes like this one have to be assessed
 from all possible sides. The proposed change is a small enhancement to the
 outputted HTML white space and at the same time a small decrease to source
 code readability mostly because it removes code highlighting.

 > Arguments like this one are wholly unproductive. The notifications from
 this ticket are causing me too much anxiety, because you're wrong ''and''
 you're not listening and you're not trying to be helpful, so I'm
 unsubscribing.

 Sorry if you feel that way, and yes, this is causing me a lot of anxiety
 too. All I tried to do was a simple review of a small code change that
 seems to slightly enhance one thing but slightly diminish another.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49059#comment:24>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list