[wp-trac] [WordPress Trac] #49059: Whitespace inside p element in wp-signup.php should be removed

[WordPress Trac]

#49059: Whitespace inside p element in wp-signup.php should be removed
--------------------------------+------------------------------------------
 Reporter:  henry.wright        |       Owner:  (none)
     Type:  enhancement         |      Status:  assigned
 Priority:  normal              |   Milestone:  5.4
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:                      |     Focuses:  multisite, coding-standards
--------------------------------+------------------------------------------
Changes (by azaozz):

 * keywords:  close =>


Comment:

 Replying to [comment:25 johnjamesjacoby]:
 > You removed mine and added yours. You disagree with my opinion and I
 disagree with yours. Would you like it if I removed your keyword and put
 mine back? Of course not.

 Uhhh, sorry I couldn't explain this better. There's no "yours" and "mine"
 keywords. I tried to review the changes in the patch and they looked "nice
 to have". But then while looking at the code noticed there were some "side
 effects" that I thought would need additional consideration. So I removed
 the "commit" keyword in order to allow for that consideration, nothing
 more :)

 > We assessed all of those sides ourselves, and came to a different
 conclusion.

 Great. If you think the enhancement here is more important than the minor
 "loss" of source code highlighting, go ahead and commit this change. I
 don't mind, as long as we are "on the same page" and the change has been
 considered from all possible sides.

 > We all have good intentions, and we all are trying our best, even when
 we do not agree. I choose to believe that’s a baseline understanding,
 particularly for all of us in this conversation after all of our lovely
 years together. 🤝

 Exactly, very well put :)

 > These are your opinions and are not representative of the coding
 standards or the opinions of others in this ticket.

 Right. While looking at the patch I also looked at all of the WP source
 code and there are quite a few cases where this is inconsistent. Also
 looked at the coding standards and they seem a bit unclear. Best course of
 action (for the future) would be to clarify the coding standards and then
 apply them across all of the code base. Of course this cannot be done from
 this ticket, it's just a "side note" here.

 (Removing the "close" keyword as it will probably be a while before the
 coding standards can be clarified and "uniform" changes applied
 everywhere.)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49059#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform