[wp-trac] [WordPress Trac] #49059: Whitespace inside p element in wp-signup.php should be removed

WordPress Trac noreply at wordpress.org
Sat Dec 21 19:32:54 UTC 2019


#49059: Whitespace inside p element in wp-signup.php should be removed
--------------------------------+------------------------------------------
 Reporter:  henry.wright        |       Owner:  johnjamesjacoby
     Type:  enhancement         |      Status:  assigned
 Priority:  normal              |   Milestone:  5.4
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  close               |     Focuses:  multisite, coding-standards
--------------------------------+------------------------------------------

Comment (by azaozz):

 Replying to [comment:12 SergeyBiryukov]:
 > `phpcbf` shows zero issues with them :)

 Yeah, not sure it can "fix" this type of concatenation.

 > Even looking at only `<h2>` tags here, `echo '<h2>' ... '</h2>'` in
 `signup_another_blog()` seems inconsistent with jumping in and out of
 `<?php` tags in similar instances in the rest of the file. I would think
 it should be one way or the other.

 Perhaps we should be "fixing" that instead of adding more and more `echo
 '<HTML>'`? :)

 Or if `echo '<HTML>'` if the "better way", lets add it everywhere? Having
 this inconsistency throughout the source code seems to be the bigger
 problem here imho :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49059#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list