[wp-trac] [WordPress Trac] #49059: Whitespace inside p element in wp-signup.php should be removed
WordPress Trac
noreply at wordpress.org
Sat Dec 21 19:42:42 UTC 2019
#49059: Whitespace inside p element in wp-signup.php should be removed
--------------------------------+------------------------------------------
Reporter: henry.wright | Owner: johnjamesjacoby
Type: enhancement | Status: assigned
Priority: normal | Milestone: 5.4
Component: Networks and Sites | Version: 3.0
Severity: normal | Resolution:
Keywords: close | Focuses: multisite, coding-standards
--------------------------------+------------------------------------------
Comment (by azaozz):
As a side note: perhaps have a look at the proposed changes to the JS
coding standards that (I hope) will also be synced with the PHP coding
standards: https://make.wordpress.org/core/2019/12/09/proposed-javascript-
coding-standards-revisions-for-prettier-compatibility/.
There concatenation "expands" vertically so things like:
{{{
echo '<p>' . sprintf(
/* translators: %s: Current user's display name. */
__( 'Welcome back, %s. By filling out the form below, you can
<strong>add another site to your account</strong>. There is no limit to
the number of sites you can have, so create to your heart’s content,
but write responsibly!' ),
$current_user->display_name
) . '</p>';
}}}
will eventually have to be written most likely like this:
{{{
echo (
'<p>' .
sprintf(
/* translators: %s: Current user's display name. */
__( 'Welcome back, %s. By filling out the form below, you can
<strong>add another site to your account</strong>. There is no limit to
the number of sites you can have, so create to your heart’s content,
but write responsibly!' ),
$current_user->display_name
) .
'</p>'
);
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/49059#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list