[wp-trac] [WordPress Trac] #49059: Whitespace inside p element in wp-signup.php should be removed

WordPress Trac noreply at wordpress.org
Sat Dec 21 19:23:40 UTC 2019


#49059: Whitespace inside p element in wp-signup.php should be removed
--------------------------------+------------------------------------------
 Reporter:  henry.wright        |       Owner:  johnjamesjacoby
     Type:  enhancement         |      Status:  assigned
 Priority:  normal              |   Milestone:  5.4
Component:  Networks and Sites  |     Version:  3.0
 Severity:  normal              |  Resolution:
 Keywords:  close               |     Focuses:  multisite, coding-standards
--------------------------------+------------------------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:7 azaozz]:
 > Looking at the patches here, it seems they are not 100% compatible with
 the coding standards?

 `phpcbf` shows zero issues with them :)

 > I've looked at quite a few of these tickets and pretty much all I've
 seen seem to miss the PHP side of things. They usually only talk about
 "prettifying" HTML output but don't consider source code readability.

 In my opinion, [attachment:"49059.2.diff"] aims to improve the consistency
 of PHP, not so much the resulting HTML.

 Even looking at only `<h2>` tags here, `echo '<h2>' ... '</h2>'` in
 `signup_another_blog()` seems inconsistent with jumping in and out of
 `<?php` tags in similar instances in the rest of the file. I would think
 it should be one way or the other.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49059#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list