[wp-trac] [WordPress Trac] #36901: Removing wp_die() from wp_allow_comment()

WordPress Trac noreply at wordpress.org
Thu Oct 6 17:21:49 UTC 2016


#36901: Removing wp_die() from wp_allow_comment()
-------------------------------------------------+-------------------------
 Reporter:  websupporter                         |       Owner:
     Type:  enhancement                          |  websupporter
 Priority:  normal                               |      Status:  reviewing
Component:  Comments                             |   Milestone:  4.7
 Severity:  normal                               |     Version:  4.6
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------

Comment (by rachelbaker):

 @mdgl Thank you for the feedback.  My thought behind adding the
 `$avoid_die` parameter to `check_comment` is allowing functions that hook
 into the action to know if the use of `wp_die()` is expected.  I am open
 to the idea that I am overthinking this and trying to cover a potential
 use-case that doesn't exist.

 Thank you for catching the missing parameter change needed on default-
 filters.php.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36901#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list