[wp-trac] [WordPress Trac] #36901: Removing wp_die() from wp_allow_comment()

[WordPress Trac]

#36901: Removing wp_die() from wp_allow_comment()
-------------------------------------------------+-------------------------
 Reporter:  websupporter                         |       Owner:
     Type:  enhancement                          |  websupporter
 Priority:  normal                               |      Status:  reviewing
Component:  Comments                             |   Milestone:  4.7
 Severity:  normal                               |     Version:  4.6
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------

Comment (by mdgl):

 The new patch (.6) looks as though it will do the job, but I don't see why
 we need to pass the `$avoid_die` [yech!] parameter into the (legacy)
 `check_comment_flood` action since there is no way for the hooked function
 to return anything. In any case, this action is declared with only three
 parameters in `default-filters.php`.

 The other backwards-compatibility issue I can think of is that now calling
 function `check_comment_flood_db()` will effectively do nothing, whereas
 previously it actually checked for a comment flood and "died" if one was
 detected.  Developers may be relying on that behaviour.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36901#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform