[wp-trac] [WordPress Trac] #38697: Twenty Seventeen: Video header pause button design

[WordPress Trac]

#38697: Twenty Seventeen: Video header pause button design
------------------------------------+----------------------------
 Reporter:  melchoyce               |       Owner:  joemcgill
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.7
Component:  Bundled Theme           |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  accessibility
------------------------------------+----------------------------

Comment (by laurelfulford):

 Thanks for the reviews and comments @davidakennedy, @joemcgill and
 @afercia!

 In [attachment:38697.4.diff] I made the following updates:

 * The filter function has been moved to custom-header.php - that makes
 more sense!
 * The button text has been hidden with `screen-reader-text` instead.
 * I switched the `id` to a `class` in the CSS - there was no reason to use
 the ID, and I agree the class is better.
 * I've switched the button to stay fixed with the video - I didn't
 consider it but it did feel a bit odd with it moving with the text, when
 it's actually video-related.
 * I've updated the strings to 'Play background video' and 'Pause
 background video' in the theme.

 Just let me know if there's anything else - thanks!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38697#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform