[wp-trac] [WordPress Trac] #38697: Twenty Seventeen: Video header pause button design
WordPress Trac
noreply at wordpress.org
Tue Nov 15 17:36:07 UTC 2016
#38697: Twenty Seventeen: Video header pause button design
------------------------------------+----------------------------
Reporter: melchoyce | Owner: joemcgill
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.7
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch dev-feedback | Focuses: accessibility
------------------------------------+----------------------------
Comment (by joemcgill):
Tested [attachment:38697.4.diff] and everything is looking good, but I
also wanted to reiterate one thing that @davidakennedy mentioned earlier:
>@melchoyce Can the button have a higher opacity or similar to increase
contrast? I love the design and realize the need to not want to overshadow
the video in this case, but right now it's really dependent on whatever
the background video is, which could be anything... so I'd love to do
better there to help combat that.
The current patch sets the style of the button based on the color scheme
setting, but as David points out, the button will overlay the video, which
won't follow the same color scheme necessarily. For example, using the
light color scheme, with a dark video, the button is pretty hard too pick
up (see screenshot below). I question whether the button color should even
be related to the color scheme or whether a we can style it with
affordances for both dark and light videos.
[[Image(https://cldup.com/DeVYy1pYGS.png)]]
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38697#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list