[wp-trac] [WordPress Trac] #38697: Twenty Seventeen: Video header pause button design

[WordPress Trac]

#38697: Twenty Seventeen: Video header pause button design
------------------------------------+----------------------------
 Reporter:  melchoyce               |       Owner:  joemcgill
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.7
Component:  Bundled Theme           |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  accessibility
------------------------------------+----------------------------
Changes (by afercia):

 * focuses:   => accessibility


Comment:

 Worth reminding this should be coordinated with #38678 where the button
 `aria-hidden` attribute is going to be removed. Since the button will now
 be available to assistive technologies, there's the need to don't use
 `display: none` on the button text but hide the text just visually,
 otherwise AT won't announce any text. It should be as simple as removing
 the current rule and add the `.video-button-text` selector to the
 `.screen-reader-text` rule.

 See screenshot with text hidden just visually, using Safari + VoiceOver:

 [[Image(https://cldup.com/tuphZTQtjR.png)]]

 I'd also propose to consider to improve a bit the two strings and make
 them a bit more meaningful, something like:
 `Pause background video`
 `Play background video`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38697#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform