[wp-trac] [WordPress Trac] #38697: Twenty Seventeen: Video header pause button design
WordPress Trac
noreply at wordpress.org
Tue Nov 15 05:56:51 UTC 2016
#38697: Twenty Seventeen: Video header pause button design
------------------------------------+------------------------
Reporter: melchoyce | Owner: joemcgill
Type: enhancement | Status: assigned
Priority: normal | Milestone: 4.7
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: has-patch dev-feedback | Focuses:
------------------------------------+------------------------
Comment (by joemcgill):
@laurelfulford [attachment:38697.3.diff] is looking good. I'd +1
@davidakennedy's recommendation to use the class instead of ID for styling
if possible. I was also surprised to see that the button scrolled upwards
with the content rather than staying fixed to the corner of the video (see
image below). Is this the intended behavior?
[[Image(https://cldup.com/PLJxeLEcx8.gif)]]
Also, re @davidakennedy:
> Asking the critical question here: Would there be a way to keep the
entire video clickable and make it more obvious that it's able to be
paused – from a design standpoint?
It is possible to make clicking the video trigger play/pause as well as
the button itself if that's desired. In fact, YouTube videos will have
that behavior by default unless we intentionally try to block click events
on the YouTube iframe, though it sounds like that could carry some
[http://stackoverflow.com/questions/17910931/disable-iframe-onclick-pause
potential legal implications].
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38697#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list