[wp-trac] [WordPress Trac] #38697: Twenty Seventeen: Video header pause button design

[WordPress Trac]

#38697: Twenty Seventeen: Video header pause button design
------------------------------------+------------------------
 Reporter:  melchoyce               |       Owner:  joemcgill
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.7
Component:  Bundled Theme           |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+------------------------

Comment (by davidakennedy):

 This is looking really good! Thanks for all the work everyone. Here's some
 feedback on the latest design and patch:

 @melchoyce Can the button have a higher opacity or similar to increase
 contrast? I love the design and realize the need to not want to overshadow
 the video in this case, but right now it's really dependent on whatever
 the background video is, which could be anything... so I'd love to do
 better there to help combat that.

 @laurelfulford The patch is working nicely and looks good.

 * What do you think about moving the filter function to the `inc/custom-
 header.php` function where the other custom header stuff is at?
 * The button text has a `display: none;` applied, meaning the button can't
 be read by screen readers. Probably an oversight. :) That can be replaced
 with `screen-reader-text`.
 * Is there a reason you styled with the `id` and not `class` in CSS? Using
 the class, `wp-custom-header-video-button` would make it easier to
 override in spots if necessary.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38697#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform